[
https://issues.apache.org/jira/browse/HBASE-16592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485393#comment-15485393
]
Ted Yu commented on HBASE-16592:
--------------------------------
Looks good overall.
Since AbstractResponse is marked Private, the following is not needed:
{code}
+ @InterfaceAudience.Private
+ public enum ResponseType {
{code}
{code}
+ SINGLE (0),
+ MULTI (1);
{code}
nit: please align the ordinal values.
{code}
+ CompareType compareType = null;
+ if (compareOp != null) {
{code}
The above is needed after unification ?
> Unify Delete request with AP
> ----------------------------
>
> Key: HBASE-16592
> URL: https://issues.apache.org/jira/browse/HBASE-16592
> Project: HBase
> Issue Type: Sub-task
> Reporter: Heng Chen
> Assignee: Heng Chen
> Attachments: HBASE-16592.patch, HBASE-16592.v1.patch,
> HBASE-16592.v1.patch
>
>
> This is the first step try to unify the HTable with AP only, to extend AP
> could process single action, i introduced AbstractResponse, multiResponse
> and singleResponse (introduced to deal with single result) will extend this
> class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
