[
https://issues.apache.org/jira/browse/HBASE-16540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485615#comment-15485615
]
Gary Helmling commented on HBASE-16540:
---------------------------------------
The patch looks good. The only minor comment I have is on javadoc added for
the methods. Where describing when IllegalArgumentException is thrown, it
would be better to actually link to the constant used for reference, ie. in
"(length exceeds MAX_ROW_LENGTH)" use "{@link HConstants#MAX_ROW_LENGTH}".
> Scan should do additional validation on start and stop row
> ----------------------------------------------------------
>
> Key: HBASE-16540
> URL: https://issues.apache.org/jira/browse/HBASE-16540
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Gary Helmling
> Assignee: Dustin Pho
> Attachments: HBASE-16540.patch
>
>
> Scan.setStartRow() and setStopRow() should validate the byte[] passed to
> ensure it meets the criteria for a row key. If the byte[] length is greater
> that Short.MAX_VALUE, we should throw an IllegalArgumentException in order to
> fast fail and prevent server-side errors being thrown and retried.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
