[
https://issues.apache.org/jira/browse/HBASE-16586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15491562#comment-15491562
]
Appy commented on HBASE-16586:
------------------------------
+1
Two minor things.
ProcedureEvent: If we don't want empty description, then maybe make default
constructor protected too. Also maybe assert in {{ProcedureEvent(String
description}} that description is not empty.
For posterity, maybe put a note on wake and wakeBatch that these are&can not be
called with common event because of possible deadlock.
> Procedure v2 - Cleanup sched wait/lock semantic
> -----------------------------------------------
>
> Key: HBASE-16586
> URL: https://issues.apache.org/jira/browse/HBASE-16586
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2
> Affects Versions: 2.0.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Fix For: 2.0.0
>
> Attachments: HBASE-16586-v0.patch, HBASE-16586-v1.patch,
> HBASE-16586-v2.patch
>
>
> For some reason waitEvent() and waitRegion() had a mismatching return value.
> unity the wait semantic in being: return true we wait, false we don't wait.
> procedures using hasLock = waitRegion() should change to hasLock =
> !waitRegion(). at the moment we have only DispatchMergingRegionsProcedure
> using it (in master).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
