[
https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493223#comment-15493223
]
Heng Chen commented on HBASE-16626:
-----------------------------------
{code}
commit 56be3ac7c8d203710f844cd799f2fa3496f0515a
Author: anoopsamjohn <[email protected]>
Date: Thu Sep 15 18:07:43 2016 +0530
HBASE-16626 User customized RegionScanner from 1.X is incompatible with
2.0.0's off-heap part. (Charlie Qiangeng Xu)
commit e6f8f6dbd0f7e801fd0fbafbe8cb35492bf08285
Merge: 156a8b2 1d6c90b
Author: anoopsamjohn <[email protected]>
Date: Thu Sep 15 18:07:12 2016 +0530
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/hbase
{code}
There is one merge action log in git log, is it OK? [~anoop.hbase]
> User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap
> part
> ---------------------------------------------------------------------------------
>
> Key: HBASE-16626
> URL: https://issues.apache.org/jira/browse/HBASE-16626
> Project: HBase
> Issue Type: Sub-task
> Components: Offheaping
> Affects Versions: 2.0.0
> Reporter: Charlie Qiangeng Xu
> Assignee: Charlie Qiangeng Xu
> Fix For: 2.0.0
>
> Attachments: HBASE-16626-v1.patch
>
>
> Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a
> new interface Shipper which contains a "shipped()" method.
> In our case, some application user defined customized scanner that implements
> Interface RegionScanner in 1.X .
> After we back ported the Off Heap feature of 2.0.0,
> RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when
> executing scanner.shipped(). It is because the customized scanner didn't
> override the shipped method yet.
> Instead of forcing every user to add a empty implementation(if they don't
> really need to scan the file or the RS don't use L2 cache, they don't need to
> do anything in shipped method) , adding a default method of shipped in
> Interface RegionScanner might be a better way.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
