[ 
https://issues.apache.org/jira/browse/HBASE-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162280#comment-13162280
 ] 

Ted Yu commented on HBASE-4944:
-------------------------------

Minor comments:
{code}
+        KeyValue pkv = null;
{code}
The variable can be named prevKV which is clearer.
{code}
+              throw new InvalidHFileException("Previous row is greater then"
{code}
Typo above, should be 'greater than'.


                
> Optionally verify bulk loaded HFiles
> ------------------------------------
>
>                 Key: HBASE-4944
>                 URL: https://issues.apache.org/jira/browse/HBASE-4944
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.92.0, 0.94.0, 0.90.5
>            Reporter: Andrew Purtell
>            Priority: Minor
>         Attachments: 4944.txt
>
>
> We rely on users to produce properly formatted HFiles for bulk import. 
> Attached patch adds an optional code path, toggled by a configuration 
> property, that verifies the HFile under consideration for import is properly 
> sorted. The default maintains the current behavior, which does not scan the 
> file for correctness.
> Patch is against trunk but can apply against all active branches.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to