[ 
https://issues.apache.org/jira/browse/HBASE-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162287#comment-13162287
 ] 

Lars Hofhansl commented on HBASE-4945:
--------------------------------------

+1 that's exactly the patch I had in mind.
                
> NPE in HRegion.bulkLoadHFiles(...)
> ----------------------------------
>
>                 Key: HBASE-4945
>                 URL: https://issues.apache.org/jira/browse/HBASE-4945
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Lars Hofhansl
>            Priority: Minor
>         Attachments: HBASE-4945.patch
>
>
> Was playing with "completebulkload", and ran into an NPE.
> The problem is here (HRegion.bulkLoadHFiles(...)).
> {code}
> Store store = getStore(familyName);
> if (store == null) {
>   IOException ioe = new DoNotRetryIOException(
>       "No such column family " + Bytes.toStringBinary(familyName));
>   ioes.add(ioe);
>   failures.add(p);
> }
> try {
>   store.assertBulkLoadHFileOk(new Path(path));
> } catch (WrongRegionException wre) {
>   // recoverable (file doesn't fit in region)
>   failures.add(p);
> } catch (IOException ioe) {
>   // unrecoverable (hdfs problem)
>   ioes.add(ioe);
> }
> {code}
> This should be 
> {code}
> Store store = getStore(familyName);
> if (store == null) {
> ...
> } else {
>   try {
>     store.assertBulkLoadHFileOk(new Path(path));
> ...
> }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to