Anoop Sam John commented on HBASE-16652:

Increment is a public exposed class and this will change the behavior of 
getTimeRange API in it.   Also pls see the usage of this API within our code.  
See AccessController
if (checkCoveringPermission(user, OpType.INCREMENT, c.getEnvironment(), 
          increment.getFamilyCellMap(), increment.getTimeRange().getMax(), 
Action.WRITE)) {
This change will make NPE here.
So instead of this can be set the TimeRange to get iff Increment is having a TR 
on it and it is not allTime?  (See   TR#isAllTime() )

> Figure out performance difference between increment and append
> --------------------------------------------------------------
>                 Key: HBASE-16652
>                 URL: https://issues.apache.org/jira/browse/HBASE-16652
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Heng Chen
>              Labels: performance
>         Attachments: HBASE-16652.patch, append.jfr, append_get_profile.png, 
> increment.jfr, increment_get_profile.png
> When do performance test in HBASE-16625,  i found it has the very big 
> difference between Append and Increment (append is about 37% faster than 
> increment).
> As [~stack] mentioned in 
> https://issues.apache.org/jira/browse/HBASE-16610?focusedCommentId=15493166&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15493166,
>    append and increment has been unified in server-side,  and they looks the 
> same in client-side. 
> This issue is to figure out why the performance looks different between them.

This message was sent by Atlassian JIRA

Reply via email to