[ https://issues.apache.org/jira/browse/HBASE-16651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502949#comment-15502949 ]
Anoop Sam John commented on HBASE-16651: ---------------------------------------- And I agree with you - May be we should remove the combinedMode = false version. Now we can have a combined mode L1 and off heap L2 cache. L1 will have the index/bloom blocks (very less size is enough) and data in L2 cache. No need to move around blocks btw L1 and L2. But still in case of combined mode = true, we will need L2 as victim for L1? When L1 is out of space cache them in L2. The blocks there are more frequently used ones > LRUBlockCache#returnBlock should try return block to Victim Handler L2 cache. > ----------------------------------------------------------------------------- > > Key: HBASE-16651 > URL: https://issues.apache.org/jira/browse/HBASE-16651 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners > Affects Versions: 2.0.0 > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-16651.patch > > > In case of L1 and L2 cache usage with combinedMode = false, L2 is used as a > victim handler cache for L1 cache. When a getBlock() request comes, L1 will > see if block is in it and if not it will try to provide the block from L2 > cache. In such a case, the return block must return the block to L2 cache and > count down the ref count for the block. But right now we just ignore the > returnBlock call in LRUCache -- This message was sent by Atlassian JIRA (v6.3.4#6332)