[ 
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15503863#comment-15503863
 ] 

Hadoop QA commented on HBASE-16264:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 163m 36s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 160 new or modified 
test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 3m 42s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 
30s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 31s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 32m 
31s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 4m 
22s {color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s 
{color} | {color:blue} Skipped patched modules with no Java source: . {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 40s 
{color} | {color:red} hbase-common in master has 1 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 44s 
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 6s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m 
9s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 34s 
{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 34s {color} | 
{color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 34s {color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 33m 
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 
53s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 1s 
{color} | {color:red} The patch has 2304 line(s) that end in whitespace. Use 
git apply --whitespace=fix. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 2m 44s 
{color} | {color:red} The patch 9 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 11s 
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
44m 1s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s 
{color} | {color:blue} Skipped patched modules with no Java source: . {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 17s 
{color} | {color:red} hbase-client generated 6 new + 0 unchanged - 0 fixed = 6 
total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 2m 37s 
{color} | {color:red} root generated 3 new + 19 unchanged - 1 fixed = 22 total 
(was 20) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 23s 
{color} | {color:red} hbase-client generated 2 new + 13 unchanged - 1 fixed = 
15 total (was 14) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 13s 
{color} | {color:red} hbase-procedure generated 6 new + 0 unchanged - 0 fixed = 
6 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 41s 
{color} | {color:red} hbase-server generated 1 new + 1 unchanged - 0 fixed = 2 
total (was 1) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 28s 
{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 23s {color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 16s 
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 12s 
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 24s 
{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 21s 
{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 13s 
{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 31s 
{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 59s {color} 
| {color:red} hbase-rest in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 23s 
{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 103m 31s 
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 10s 
{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 40s 
{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 3m 57s 
{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 490m 14s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-client |
|  |  Private method 
org.apache.hadoop.hbase.MetaTableAccessor.mutationsToString(Mutation[]) is 
never called  At MetaTableAccessor.java:called  At 
MetaTableAccessor.java:[lines 2069-2075] |
|  |  instanceof will always return true for all non-null values in 
org.apache.hadoop.hbase.client.RegionServerCallable.call(int), since all 
org.apache.hadoop.hbase.shaded.com.google.protobuf.RpcController are instances 
of org.apache.hadoop.hbase.shaded.com.google.protobuf.RpcController  At 
RegionServerCallable.java:for all non-null values in 
org.apache.hadoop.hbase.client.RegionServerCallable.call(int), since all 
org.apache.hadoop.hbase.shaded.com.google.protobuf.RpcController are instances 
of org.apache.hadoop.hbase.shaded.com.google.protobuf.RpcController  At 
RegionServerCallable.java:[line 88] |
|  |  Unchecked/unconfirmed cast from 
org.apache.hadoop.hbase.ipc.BlockingRpcCallback<org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos$VisibilityLabelsResponse>
 to com.google.protobuf.RpcCallback in 
org.apache.hadoop.hbase.security.visibility.VisibilityClient$1.call(VisibilityLabelsProtos$VisibilityLabelsService)
  At VisibilityClient.java:com.google.protobuf.RpcCallback in 
org.apache.hadoop.hbase.security.visibility.VisibilityClient$1.call(VisibilityLabelsProtos$VisibilityLabelsService)
  At VisibilityClient.java:[line 144] |
|  |  Unchecked/unconfirmed cast from 
org.apache.hadoop.hbase.ipc.BlockingRpcCallback<org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos$GetAuthsResponse>
 to com.google.protobuf.RpcCallback in 
org.apache.hadoop.hbase.security.visibility.VisibilityClient$2.call(VisibilityLabelsProtos$VisibilityLabelsService)
  At VisibilityClient.java:com.google.protobuf.RpcCallback in 
org.apache.hadoop.hbase.security.visibility.VisibilityClient$2.call(VisibilityLabelsProtos$VisibilityLabelsService)
  At VisibilityClient.java:[line 223] |
|  |  Unchecked/unconfirmed cast from 
org.apache.hadoop.hbase.ipc.BlockingRpcCallback<org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos$ListLabelsResponse>
 to com.google.protobuf.RpcCallback in 
org.apache.hadoop.hbase.security.visibility.VisibilityClient$3.call(VisibilityLabelsProtos$VisibilityLabelsService)
  At VisibilityClient.java:com.google.protobuf.RpcCallback in 
org.apache.hadoop.hbase.security.visibility.VisibilityClient$3.call(VisibilityLabelsProtos$VisibilityLabelsService)
  At VisibilityClient.java:[line 281] |
|  |  Unchecked/unconfirmed cast from 
org.apache.hadoop.hbase.ipc.BlockingRpcCallback<org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos$VisibilityLabelsResponse>
 to com.google.protobuf.RpcCallback in 
org.apache.hadoop.hbase.security.visibility.VisibilityClient$4.call(VisibilityLabelsProtos$VisibilityLabelsService)
  At VisibilityClient.java:com.google.protobuf.RpcCallback in 
org.apache.hadoop.hbase.security.visibility.VisibilityClient$4.call(VisibilityLabelsProtos$VisibilityLabelsService)
  At VisibilityClient.java:[line 359] |
| Failed junit tests | 
hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths |
|   | hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack |
|   | hadoop.hbase.security.visibility.TestWithDisabledAuthorization |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService 
|
|   | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsReplication |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString |
|   | hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator |
|   | hadoop.hbase.wal.TestWALSplitCompressed |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL |
|   | hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels |
|   | hadoop.hbase.wal.TestWALSplit |
|   | hadoop.hbase.security.visibility.TestVisibilityLablesWithGroups |
|   | hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack |
|   | hadoop.hbase.rest.TestScannersWithLabels |
|   | hadoop.hbase.rest.TestScannersWithLabels |
|   | hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths |
|   | hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack |
|   | hadoop.hbase.security.visibility.TestWithDisabledAuthorization |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService 
|
|   | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsReplication |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString |
|   | hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator |
|   | hadoop.hbase.wal.TestWALSplitCompressed |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL |
|   | hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels |
|   | hadoop.hbase.wal.TestWALSplit |
|   | hadoop.hbase.security.visibility.TestVisibilityLablesWithGroups |
|   | hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack |
| Timed out junit tests | 
org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
|   | org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.0 Server=1.12.0 Image:yetus/hbase:7bda515 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12829158/HBASE-16264.master.009.patch
 |
| JIRA Issue | HBASE-16264 |
| Optional Tests |  asflicense  javac  javadoc  unit  xml  compile  findbugs  
hadoopcheck  hbaseanti  checkstyle  cc  hbaseprotoc  |
| uname | Linux 67c25e11f6ec 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 6eb6225 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/branch-findbugs-hbase-common-warnings.html
 |
| compile | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/patch-compile-root.txt
 |
| cc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/patch-compile-root.txt
 |
| javac | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/patch-compile-root.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/whitespace-eol.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/whitespace-tabs.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/new-findbugs-hbase-client.html
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/diff-javadoc-javadoc-root.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/diff-javadoc-javadoc-hbase-client.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/diff-javadoc-javadoc-hbase-procedure.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/patch-unit-root.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/patch-unit-hbase-rest.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/patch-unit-hbase-server.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/patch-unit-root.txt
 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/patch-unit-hbase-rest.txt
 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/artifact/patchprocess/patch-asflicense-problems.txt
 |
| modules | C: hbase-protocol-shaded . hbase-client hbase-common hbase-examples 
hbase-it hbase-procedure hbase-protocol hbase-rest hbase-rsgroup hbase-server 
hbase-spark hbase-thrift U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/3600/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Figure how to deal with endpoints and shaded pb
> -----------------------------------------------
>
>                 Key: HBASE-16264
>                 URL: https://issues.apache.org/jira/browse/HBASE-16264
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors, Protobufs
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: 16264.tactic2.patch, HBASE-16264.master.001.patch, 
> HBASE-16264.master.002.patch, HBASE-16264.master.003.patch, 
> HBASE-16264.master.004.patch, HBASE-16264.master.005.patch, 
> HBASE-16264.master.006.patch, HBASE-16264.master.007.patch, 
> HBASE-16264.master.008.patch, HBASE-16264.master.009.patch
>
>
> Come up w/ a migration plan for coprocessor endpoints when our pb is shaded. 
> Would be sweet if could make it so all just worked. At worst, come up w/ a 
> prescription for how to migrate existing CPs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to