[ 
https://issues.apache.org/jira/browse/HBASE-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15504374#comment-15504374
 ] 

Andrew Purtell commented on HBASE-15984:
----------------------------------------

+1

Patch also introduces metrics changes. That's maybe 50% of the bulk of the 
diff. 

Are we ok with metrics changes in patch releases? I think it's analogous to an 
API addition. After an upgrade, a change to a metrics system to report on the 
new metrics will fail to receive data after a downgrade. In my opinion this is 
fine, certainly for a minor release, so commit to master, branch-1, and 0.98 
will be fine. (That 0.98 commit will need work to add Hadoop 1 compat metrics, 
I can do that.) For 1.1 and 1.2 I defer to the RMs [~ndimiduk] and [~busbey]

> Given failure to parse a given WAL that was closed cleanly, replay the WAL.
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-15984
>                 URL: https://issues.apache.org/jira/browse/HBASE-15984
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Replication
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Critical
>             Fix For: 2.0.0, 1.0.4, 1.4.0, 1.3.1, 1.1.7, 0.98.23, 1.2.4
>
>         Attachments: HBASE-15984.1.patch, HBASE-15984.2.patch
>
>
> subtask for a general work around for "underlying reader failed / is in a bad 
> state" just for the case where a WAL 1) was closed cleanly and 2) we can tell 
> that our current offset ought not be the end of parseable entries.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to