Hiroshi Ikeda commented on HBASE-16648:

I read just halfway the patch, but behaviors of Map.computeIfAbsent depend on 
their implementations. For example, CopyOnWriteArrayMap defined in HBase uses 
the default implementation, which means MetaCache in the patch is wrong at 
least. ConcurrentHashMap uses an exclusive lock and has possibility to reduce 
performance. The contract of WeakObjectPool is changed with the possibility in 
the patch and you should do something about that.

> [JDK8] Use computeIfAbsent instead of get and putIfAbsent
> ---------------------------------------------------------
>                 Key: HBASE-16648
>                 URL: https://issues.apache.org/jira/browse/HBASE-16648
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Performance
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>         Attachments: HBASE-16648-v1.patch, HBASE-16648.patch

This message was sent by Atlassian JIRA

Reply via email to