[
https://issues.apache.org/jira/browse/HBASE-16587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508627#comment-15508627
]
Matteo Bertozzi commented on HBASE-16587:
-----------------------------------------
https://reviews.apache.org/r/52110/
TestSuspended is the one testing the holdLock,
TestMasterProcedureEvents#testTimeoutEventProcedure is testing the suspended
with events, and for that I don't need any kind of lock.
the combination holdLock() && hasLock() is because I need a flag to say if I
have to retain the lock. holdLock() is just a "flag" that says "I want to
retain the lock once I grab it"
> Procedure v2 - Cleanup suspended proc execution
> -----------------------------------------------
>
> Key: HBASE-16587
> URL: https://issues.apache.org/jira/browse/HBASE-16587
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2
> Affects Versions: 2.0.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Fix For: 2.0.0
>
> Attachments: HBASE-16587-v0.patch, HBASE-16587-v1.patch,
> HBASE-16587-v2.patch, HBASE-16587-v3.patch
>
>
> for procedures like the assignment or the lock one we need to be able to hold
> on locks while suspended. At the moment the way to do that is up to the proc
> implementation. This patch moves the logic to the base Procedure and
> ProcedureExecutor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
