Heng Chen commented on HBASE-16659:

we can make it to use with out copy. We might need new API in CellUtil and new 
version of EmptyCell extension. Am ok commit this patch as such and fix the 
above in another jira.

Agreed.  we need new interface in CellUtil, open another issue for it.   


will commit it if no other concerns.  :)

> Use CellUtil.createFirstOnRow instead of KeyValueUtil.createFirstOnRow in 
> some places. 
> ---------------------------------------------------------------------------------------
>                 Key: HBASE-16659
>                 URL: https://issues.apache.org/jira/browse/HBASE-16659
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: binlijin
>            Assignee: binlijin
>            Priority: Minor
>             Fix For: 2.0.0
>         Attachments: HBASE-16659-master.patch, HBASE-16659-master_v2.patch, 
> HBASE-16659-master_v2.patch
> CellUtil.createFirstOnRow is more effective than 
> KeyValueUtil.createFirstOnRow, because there is no byte[] copy.
> Current in ReversedRegionScannerImpl#nextRow, to get the previous row to 
> seek, it use KeyValueUtil.createFirstOnRow which will have two copy, the 
> first copy is copy to a tmp byte[], the second copy is in KeyValue. We can 
> use CellUtil.createFirstOnRow which will have no copy.

This message was sent by Atlassian JIRA

Reply via email to