[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509572#comment-15509572 ]
Anoop Sam John commented on HBASE-16665: ---------------------------------------- AbstractMemStore#updateColumnValue change seems not needed at all as we are not using this in code path. This API used by tests alone.. We should get rid of this. The other place in AbstractMemStore though we must change. (The one u mentioned). This can be changed also.. We might need to add new API in CellUtil. Or else use CellUtil#createFirstOnRowColTS and pass the LATEST_TIMESTAMP. {code} // Used only for testing purposes static MatchCode checkColumn(ColumnTracker columnTracker, byte[] bytes, int offset, int length, long ttl, byte type, boolean ignoreCount) throws IOException { KeyValue kv = KeyValueUtil.createFirstOnRow(HConstants.EMPTY_BYTE_ARRAY, 0, 0, HConstants.EMPTY_BYTE_ARRAY, 0, 0, bytes, offset, length); {code} Used only by tests. We can just ignore and no need to change IMO. > Check whether KeyValueUtil.createXXX could be replaced by CellUtil without > copy > ------------------------------------------------------------------------------- > > Key: HBASE-16665 > URL: https://issues.apache.org/jira/browse/HBASE-16665 > Project: HBase > Issue Type: Bug > Reporter: Heng Chen > Attachments: HBASE-16665.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)