[ 
https://issues.apache.org/jira/browse/HBASE-16423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510275#comment-15510275
 ] 

Ted Yu commented on HBASE-16423:
--------------------------------

{code}
125             sleepToReCompare = conf.getInt(NAME +".sleepToReCompare", 0);
{code}
How about naming the parameter sleepMsBeforeReCompare ?
{code}
+          return;
+        } catch (Exception e) {
+          LOG.error("recompare fail!");
{code}
Can you log more information in the error (such as row key) ?
{code}
+    System.err.println(" recomparesleep   milliseconds to sleep before 
recompare row.");
{code}
Please mention that value 0 disables recomparison.

> Add re-compare option to VerifyReplication to avoid occasional inconsistent 
> rows
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-16423
>                 URL: https://issues.apache.org/jira/browse/HBASE-16423
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>    Affects Versions: 2.0.0
>            Reporter: Jianwei Cui
>            Priority: Minor
>         Attachments: HBASE-16423-v1.patch
>
>
> Because replication keeps eventually consistency, VerifyReplication may 
> report inconsistent rows if there are data being written to source or peer 
> clusters during scanning. These occasionally inconsistent rows will have the 
> same data if we do the comparison again after a short period. It is not easy 
> to find the really inconsistent rows if VerifyReplication report a large 
> number of such occasionally inconsistency. To avoid this case, we can add an 
> option to make VerifyReplication read out the inconsistent rows again after 
> sleeping a few seconds and re-compare the rows during scanning. This behavior 
> follows the eventually consistency of hbase's replication. Suggestions and 
> discussions are welcomed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to