[
https://issues.apache.org/jira/browse/HBASE-16677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514732#comment-15514732
]
Guang Yang commented on HBASE-16677:
------------------------------------
Thanks [~enis] for looking at the patch.
{quote}
Do we actually stop rendering here? I did not see it. Have you tested with more
than 10K regions?
{quote}
The rendering part is in the *if* block, thus if it reaches to the threshold,
it would stop rendering more regions. I didn't test it with 10K but I tested
with query parameter like "numRegions=10" and it truncate the number of
regions to 10 in this case.
{quote}
Please use TraditionalBinaryPrefix.long2String() instead of this:
{quote}
It does not seem fit since here the store file is already MB, and in order to
leverage it, we will need to convert it back to B and then call that method?
{quote}
Can we please change the param name from regions to numRegions, and also have a
link in the warning message to the same page with the parameter set to render
all regions.
{quote}
Fixed, thanks.
> Add table size (total store file size) to table page
> ----------------------------------------------------
>
> Key: HBASE-16677
> URL: https://issues.apache.org/jira/browse/HBASE-16677
> Project: HBase
> Issue Type: New Feature
> Components: website
> Reporter: Guang Yang
> Priority: Minor
> Attachments: HBASE-16677_v0.patch, HBASE-16677_v1.patch,
> HBASE-16677_v2.patch, mini_cluster_master.png, prod_cluster_partial.png
>
>
> Currently there is not an easy way to get the table size from the web UI,
> though we have the region size on the page, it is still convenient to have a
> table for the table size stat.
> Another pain point is that when the table grow large with tens of thousands
> of regions, it took extremely long time to load the page, however, sometimes
> we don't want to check all the regions. An optimization could be to accept a
> query parameter to specify the number of regions to render.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
