[ 
https://issues.apache.org/jira/browse/HBASE-16666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517663#comment-15517663
 ] 

Ted Yu commented on HBASE-16666:
--------------------------------

{code}
+    def append_peer_namespaces(id, namespaces)
{code}
The above method should be named add_peer_namespaces() since Set is used 
underneath.

Looks good overall.

> Add append and remove peer namespaces cmds for replication
> ----------------------------------------------------------
>
>                 Key: HBASE-16666
>                 URL: https://issues.apache.org/jira/browse/HBASE-16666
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>            Priority: Minor
>         Attachments: HBASE-16666-v1.patch, HBASE-16666.patch
>
>
> After HBASE-16447, we support replication by namespaces config in peer. Like 
> append_peer_tableCFs and remove_peer_tableCFs, I thought we need two new 
> shell cmd:  append_peer_namespaces and remove_peer_namespaces. Then we can 
> easily change the namespaces config.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to