[
https://issues.apache.org/jira/browse/HBASE-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522626#comment-15522626
]
Anoop Sam John commented on HBASE-16704:
----------------------------------------
Yes. The changes in write methods in BufferedDataBlockEncoder is alone to fix
this. We were writing the 2 extra bytes of tagsLen even when it is 0. But the
size calculation in KVUtil#length(Cell) is not including tagsLen when it is 0.
Ya Let the change in HFileReader be here in this patch.. For KeyValue, there
is no need to include the tagsLen bytes in buffer when it is 0.
bq.Since we skipping in the right way the above change should be fine.
Ya that is just a method rename to say more clearly what it is doing.
bq.The changes to CellUtil are part of this JIRA fix or just a refactor?
No just an improvement. In these methods u can see the lengths we calc at
first. Only the last statements were not using them. Again we call Cell
getters. Why to parse the lengths again. I just noticed this while debugging.
So thought let it go in.
> Scan will be broken while working with DBE and KeyValueCodecWithTags
> --------------------------------------------------------------------
>
> Key: HBASE-16704
> URL: https://issues.apache.org/jira/browse/HBASE-16704
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Yu Sun
> Assignee: Anoop Sam John
> Fix For: 2.0.0
>
> Attachments: HBASE-16704.patch
>
>
> scan will always broken if we set LIMIT more than 1 with rs
> hbase.client.rpc.codec set to
> org.apache.hadoop.hbase.codec.KeyValueCodecWithTags.
> How to reproduce:
> 1. 1 master + 1 rs, codec use KeyValueCodecWithTags.
> 2. create a table table_1024B_30g，1 cf and with only 1 qualifier, then load
> some data with ycsb，. Use Diff DataBlockEncoding
> 3. scan 'table_1024B_30g', {LIMIT => 2, STARTROW => 'user5499'}, STARTROW is
> set any valid start row.
> 4. scan failed.
> this should be bug in KeyValueCodecWithTags, after some investigations, I
> found some the key not serialized correctly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
