[ https://issues.apache.org/jira/browse/HBASE-16134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525591#comment-15525591 ]
ramkrishna.s.vasudevan commented on HBASE-16134: ------------------------------------------------ {code} if (withTags && this.tags != null) { 529 out.write(this.tags); 530 len += this.tags.length; 531 } 532 return len; 533 } {code} This tags array already has the tag len in it? Just asking. Rest LGTM. +1. > Introduce Cell extension for server side. > ----------------------------------------- > > Key: HBASE-16134 > URL: https://issues.apache.org/jira/browse/HBASE-16134 > Project: HBase > Issue Type: Sub-task > Components: regionserver > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-16134.patch, HBASE-16134.patch, > HBASE-16134_V2.patch, HBASE-16134_V3.patch, HBASE-16134_V3.patch > > > Came after the discussion under HBASE-15721 and HBASE-15879. > InternalCell is a Cell extension. We do have Cell extensions across different > interfaces now. > SettableSeqId > SettableTimestamp > Streamable. > And demand for this keep growing. > So let us include everything into one Interface. -- This message was sent by Atlassian JIRA (v6.3.4#6332)