[ 
https://issues.apache.org/jira/browse/HBASE-16661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527716#comment-15527716
 ] 

Gary Helmling commented on HBASE-16661:
---------------------------------------

The 002 patch looks good to me.  The only minor comment is to add a 
LAST_MAJOR_COMPACTION_DESC constant to use as a short description of the metric 
in MetricsRegionSourceImpl, instead of just reusing the metric name.

> Add last major compaction age to per-region metrics
> ---------------------------------------------------
>
>                 Key: HBASE-16661
>                 URL: https://issues.apache.org/jira/browse/HBASE-16661
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Gary Helmling
>            Assignee: Dustin Pho
>            Priority: Minor
>         Attachments: HBASE-16661.001.patch, HBASE-16661.002.patch
>
>
> After HBASE-12859, we can now track the last major compaction timestamp for 
> each region.  However, this is only exposed through cluster status reporting 
> and the admin API.
> We have similar per-region metrics around storefile age, but none that 
> filters on major compaction specifically.
> Let's add a metric for last major compaction age.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to