[
https://issues.apache.org/jira/browse/HBASE-16741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-16741:
--------------------------
Attachment: 16741.patch
Here is patch. Means we are checking in protobuf src file. They have their
3-clause BSD license on them which should be ok according to
https://www.apache.org/legal/resolved.html
> Amend the generate protobufs out-of-band build step to include shade, pulling
> in protobuf source and a hook for patching protobuf
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-16741
> URL: https://issues.apache.org/jira/browse/HBASE-16741
> Project: HBase
> Issue Type: Sub-task
> Components: Protobufs
> Reporter: stack
> Assignee: stack
> Attachments: 16741.patch
>
>
> As part of the protobuf shading work, I need to amend the build step that
> builds protobuf sources. For the module used by hbase internally -- the one
> that has our protos and that does the protobuf shading -- I need to enhance
> the generate protobuf sources step to also do:
> * Shading/relocating so we avoid clashing with protos used by CPEPs out in
> the hbase-protocol module.
> * Pulling down the protobuf lib and including its sources to make IDEs happy
> else they'll moan about missing (shaded) protobuf.
> * A hook that allows us to patch protobuf lib, at least temporarily until
> our needed changes make it upstream.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
