[ 
https://issues.apache.org/jira/browse/HBASE-16699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

huaxiang sun updated HBASE-16699:
---------------------------------
    Description: 
It seems that there are more overflow in other places, and a concurrent issue.
I will post a patch within one or 2 days after I figure out adding new unittest 
cases.

Please see the following two lines. Once it overflows, it will cause wrong 
behavior. For unconfigured RateLimiters, we should have simpler logic to byPass 
the check. 

https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/AverageIntervalRateLimiter.java#L37

https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/AverageIntervalRateLimiter.java#L51

  was:
Please see the following two lines. Once it overflows, it will cause wrong 
behavior. For unconfigured RateLimiters, we should have simpler logic to byPass 
the check. 

https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/AverageIntervalRateLimiter.java#L37

https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/AverageIntervalRateLimiter.java#L51


> Overflows in AverageIntervalRateLimiter's refill() and getWaitInterval()
> ------------------------------------------------------------------------
>
>                 Key: HBASE-16699
>                 URL: https://issues.apache.org/jira/browse/HBASE-16699
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.4.0
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>
> It seems that there are more overflow in other places, and a concurrent issue.
> I will post a patch within one or 2 days after I figure out adding new 
> unittest cases.
> Please see the following two lines. Once it overflows, it will cause wrong 
> behavior. For unconfigured RateLimiters, we should have simpler logic to 
> byPass the check. 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/AverageIntervalRateLimiter.java#L37
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/AverageIntervalRateLimiter.java#L51



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to