[
https://issues.apache.org/jira/browse/HBASE-11354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545922#comment-15545922
]
Andrew Purtell commented on HBASE-11354:
----------------------------------------
This is an interesting case:
bq. +1 unit 1m 18s hbase-client in the patch passed.
So the patch changed only a file in hbase-client, so only hbase-client was
tested, which does not start up a minicluster.
> HConnectionImplementation#DelayedClosing does not start
> -------------------------------------------------------
>
> Key: HBASE-11354
> URL: https://issues.apache.org/jira/browse/HBASE-11354
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.99.0, 0.98.3
> Reporter: Qianxi Zhang
> Assignee: Qianxi Zhang
> Priority: Minor
> Fix For: 0.98.23
>
> Attachments: HBASE-11354-0.98.patch, HBASE_11354 (1).patch,
> HBASE_11354.patch, HBASE_11354.patch, HBASE_11354.patch
>
>
> The method "createAndStart" in class DelayedClosing only creates a instance,
> but forgets to start it. So thread delayedClosing is not running all the time.
> ConnectionManager#1623
> {code}
> static DelayedClosing createAndStart(HConnectionImplementation hci){
> Stoppable stoppable = new Stoppable() {
> private volatile boolean isStopped = false;
> @Override public void stop(String why) { isStopped = true;}
> @Override public boolean isStopped() {return isStopped;}
> };
> return new DelayedClosing(hci, stoppable);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)