[
https://issues.apache.org/jira/browse/HBASE-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163946#comment-13163946
]
Phabricator commented on HBASE-4908:
------------------------------------
stack has commented on the revision "[jira] [HBASE-4908] HBase cluster test
tool (port from 0.89-fb)".
This is looking great Mikhail.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/EmptyWatcher.java:28 When would I want
one of these?
src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java:176 Is
this from another issue Mikhail? (No matter if it is... we can take care of it
on commit).
src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java:37
Thanks for doing this.
src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogReader.java:111
Thanks for fixing this.
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:1798 Good
src/test/java/org/apache/hadoop/hbase/util/IntegrationTestTool.java:39 Will
this be run as an IntegrationTest because it has the IntegrationTest prefix;
(see the Integration Test section on this page,
http://hbase.apache.org/book/hbase.tests.html, if you don't have cluse what I'm
on about)?
I like the idea of this class. We need it. Nice how you subclass tool.
src/test/java/org/apache/hadoop/hbase/util/LoadTest.java:40 Should this class
have the IntegrationTest prefix or you think this is just a tool not part of
IntegrationTests?
Since its sitting beside PerformanceEvaluation tool, should you say something
on how it differs from it?
src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java:37 Should
this be an IntegrationTest? (We can do the convertion in another issue).
REVISION DETAIL
https://reviews.facebook.net/D549
> HBase cluster test tool (port from 0.89-fb)
> -------------------------------------------
>
> Key: HBASE-4908
> URL: https://issues.apache.org/jira/browse/HBASE-4908
> Project: HBase
> Issue Type: Sub-task
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: 0001-HBase-cluster-test-tool.patch, D549.1.patch,
> D549.2.patch, D549.3.patch, D549.4.patch, D549.5.patch, D549.6.patch,
> D549.7.patch
>
>
> Porting one of our HBase cluster test tools (a single-process multi-threaded
> load generator and verifier) from 0.89-fb to trunk.
> I cleaned up the code a bit compared to what's in 0.89-fb, and discovered
> that it has some features that I have not tried yet (some kind of a kill
> test, and some way to run HBase as multiple processes on one machine).
> The main utility of this piece of code for us has been the HBaseClusterTest
> command-line tool (called HBaseTest in 0.89-fb), which we usually invoke as a
> load test in our five-node dev cluster testing, e.g.:
> hbase org.apache.hadoop.hbase.manual.HBaseTest -load 1000000000:50:100:20 -tn
> load_test -read 1:1000000000:50:20 -zk <zk_quorum> -bloom ROWCOL -compression
> GZIP
> I will be using this code to load-test the delta encoding patch and making
> fixes, but I am submitting the patch for early feedback. I will probably try
> out its other functionality and comment on how it works.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
