[ 
https://issues.apache.org/jira/browse/HBASE-16146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547267#comment-15547267
 ] 

Enis Soztutar commented on HBASE-16146:
---------------------------------------

bq. And it still won't help the situation when running on Java < 8
I've seen somebody fork the LongAdder / Stripe64 code internally. Not sure 
whether we can do that from a licensing perspective. 
bq. In some tests/workloads we did see scenarios when excessive thread locals 
allocations for counters in metrics cause load / latency on the hot machines to 
go up, impairing stability.
I've also seen these TLs come up in profiling, but did not spend too much time. 

+1 on the patch if we are not forking the code. 

> Counters are expensive...
> -------------------------
>
>                 Key: HBASE-16146
>                 URL: https://issues.apache.org/jira/browse/HBASE-16146
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>         Attachments: HBASE-16146.branch-1.3.001.patch, counters.patch, 
> less_and_less_counters.png
>
>
> Doing workloadc, perf shows 10%+ of CPU being spent on counter#add. If I 
> disable some of the hot ones -- see patch -- I can get 10% more throughput 
> (390k to 440k). Figure something better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to