[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567272#comment-15567272
]
Heng Chen commented on HBASE-16664:
-----------------------------------
Now during multi requests, we first split the requests by each RS, and call
them simultaneously with multi threads. You extract TimeTracker into
AsyncRequestFutureImpl and pass it into callable during multi-request call, all
of them share one TimeTracker? I think operationTimeout is meaningful for one
operation NOT for multi operations and it seems has race condition for
TimeTracker with multi threads.
I know now in AP for multi-request (batch, put), we recreate callable for each
retry and TimeTracker will be reset. As original logical, operationTimeout
has only relationship with single-request (We ignore it during batch and put
and just use rpcTimeout), i think it is reasonable because operationTimeout
should only affect one operation NOT for batch operations.
wdyt? [~yangzhe1991] [~Apache9] [~stack]
> Timeout logic in AsyncProcess is broken
> ---------------------------------------
>
> Key: HBASE-16664
> URL: https://issues.apache.org/jira/browse/HBASE-16664
> Project: HBase
> Issue Type: Bug
> Reporter: Phil Yang
> Assignee: Phil Yang
> Attachments: 1.patch, HBASE-16664-branch-1-v1.patch,
> HBASE-16664-branch-1-v1.patch, HBASE-16664-branch-1.1-v1.patch,
> HBASE-16664-branch-1.2-v1.patch, HBASE-16664-branch-1.3-v1.patch,
> HBASE-16664-v1.patch, HBASE-16664-v2.patch, HBASE-16664-v3.patch,
> HBASE-16664-v4.patch, HBASE-16664-v5.patch, testhcm.patch
>
>
> Have not checked the root cause, but I think timeout of all operations in
> AsyncProcess is broken
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
