[ 
https://issues.apache.org/jira/browse/HBASE-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164613#comment-13164613
 ] 

Jean-Daniel Cryans commented on HBASE-3857:
-------------------------------------------

Any reason why this patch is removing compaction and flush queue sizes?

{code}
-    this.metrics.compactionQueueSize.set(compactSplitThread
-        .getCompactionQueueSize());
-    this.metrics.flushQueueSize.set(cacheFlusher
-        .getFlushQueueSize());
{code}

If it was intentional, there's a bunch of dead code that also needs to be 
removed like those methods that were called. If it wasn't, meaning there's 
currently no way in 0.92 to get the compaction queue size, then this would be 
sufficient for me to kill the RC.
                
> Change the HFile Format
> -----------------------
>
>                 Key: HBASE-3857
>                 URL: https://issues.apache.org/jira/browse/HBASE-3857
>             Project: HBase
>          Issue Type: New Feature
>    Affects Versions: 0.90.4
>            Reporter: Liyin Tang
>            Assignee: Mikhail Bautin
>         Attachments: 0001-Adding-release-notes-for-HBASE-3857.patch, 
> 0001-Fix-TestHFileBlock.testBlockHeapSize.patch, 
> 0001-review_hfile-v2-r1144693_2011-07-15_11_14_44.patch, 
> 0001-review_hfile-v2-r1147350_2011-07-26_11_55_59.patch, 
> 0001-review_hfile-v2-r1152122-2011_08_01_03_18_00.patch, 
> 0001-review_hfile-v2-r1153300-git-1152532-2011_08_02_19_4.patch, 
> 0001-review_hfile-v2-r1153300-git-1152532-2011_08_03_12_4.patch, 
> hfile_format_v2_design_draft_0.1.pdf, hfile_format_v2_design_draft_0.3.pdf, 
> hfile_format_v2_design_draft_0.4.odt
>
>
> In order to support HBASE-3763 and HBASE-3856, we need to change the format 
> of the HFile. The new format proposal is attached here. Thanks for Mikhail 
> Bautin for the documentation. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to