stack commented on HBASE-16664:

Patch looks good to me. Default operational timeout is forever in essence 
(1200000). It has a +1 from [~chenheng]. You can set operation timeout on both 
Table level and BufferedMutator level which is good for being able to give fat 
puts their own longer, timeout. Not covered is special-handling of big 
multigets but at least can get separate Table instance to do these w/ own 
longer timeouts.

Are the test failures related?

Good stuff.

> Timeout logic in AsyncProcess is broken
> ---------------------------------------
>                 Key: HBASE-16664
>                 URL: https://issues.apache.org/jira/browse/HBASE-16664
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>         Attachments: 1.patch, HBASE-16664-branch-1-v1.patch, 
> HBASE-16664-branch-1-v1.patch, HBASE-16664-branch-1-v2.patch, 
> HBASE-16664-branch-1.1-v1.patch, HBASE-16664-branch-1.2-v1.patch, 
> HBASE-16664-branch-1.3-v1.patch, HBASE-16664-branch-1.3-v2.patch, 
> HBASE-16664-v1.patch, HBASE-16664-v2.patch, HBASE-16664-v3.patch, 
> HBASE-16664-v4.patch, HBASE-16664-v5.patch, HBASE-16664-v6.patch, 
> HBASE-16664-v7.patch, testhcm.patch
> Rpc/operation timeout logic in AsyncProcess is broken. And Table's 
> set*Timeout does not take effect in its AP or BufferedMutator.

This message was sent by Atlassian JIRA

Reply via email to