Appy commented on HBASE-16812:

so looking around, we take locks from:
- mob compaction chore in master
- sweeper chore in master
- compaction from regions

If compaction tool triggers compact, then no locks are being taken.
(In fact, it's not even triggering mob compaction. [~jingcheng...@intel.com], 
can you please take on this jira and fix that.)

If ExpiredMobFileCleaner is triggered from command line, then no locks are 
Shouldn't we also take locks when these stuff are triggered from tools?

> Cleanup deprecated compact() function
> -------------------------------------
>                 Key: HBASE-16812
>                 URL: https://issues.apache.org/jira/browse/HBASE-16812
>             Project: HBase
>          Issue Type: Task
>            Reporter: Appy
>            Assignee: Appy
>            Priority: Minor
>         Attachments: HBASE-16812.master.001.patch
> compact(CompactionContext compaction, CompactionThroughputController 
> throughputController) is [deprecated in 1.2.0 
> release|https://github.com/apache/hbase/blob/rel/1.2.0/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java#L222].
> Store.java is also marked limited private.
> Context: I was cleaning up zk table lock which is also used in that method's 
> [override|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HMobStore.java#L460]
>  in HMobStore.
> This method isn't being called from anywhere except CompactionTool (which 
> creates HStore object, not HMobStore object).
> [~jingcheng...@intel.com] Can you PTAL and help me understand what's going on.

This message was sent by Atlassian JIRA

Reply via email to