Heng Chen commented on HBASE-16653:

Due to we modify proto object of ReplicationPeerConfig (add tableCFs field),  
so when we do rolling update,  we have to update original ReplicationPeerConfig 
data on ZK firstly (See TableCFsUpdater.java).  This means during rolling 
update,  if one peer with namespace added, replication on old regionserver 
could not work. We have to wait for the rolling update completed. This is the 
big problem about HBASE-11393 for rolling update.  Could we accepte it for 
already released branch? 

As for the patch v3,  totally it looks good to me.  But why changes for rb 
scripts of shell not be backported?


> Backport HBASE-11393 to all branches which support namespace
> ------------------------------------------------------------
>                 Key: HBASE-16653
>                 URL: https://issues.apache.org/jira/browse/HBASE-16653
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.4.0, 1.0.5, 1.3.1, 0.98.22, 1.1.7, 1.2.4
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>             Fix For: 1.4.0
>         Attachments: HBASE-16653-branch-1-v1.patch, 
> HBASE-16653-branch-1-v2.patch, HBASE-16653-branch-1-v3.patch
> As HBASE-11386 mentioned, the parse code about replication table-cfs config 
> will be wrong when table name contains namespace and we can only config the 
> default namespace's tables in the peer. It is a bug for all branches which 
> support namespace. HBASE-11393 resolved this by use a pb object but it was 
> only merged to master branch. Other branches still have this problem. I 
> thought we should fix this bug in all branches which support namespace.

This message was sent by Atlassian JIRA

Reply via email to