[ 
https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575157#comment-15575157
 ] 

ramkrishna.s.vasudevan commented on HBASE-16729:
------------------------------------------------

+1 on patch. 
Will commit this to 2.0 branch.
{code}
for (int i = 0; i != count; ++i) {
{code}
Why is that it is not checked for <=?. LGTM.

> Define the behavior of (default) empty FilterList
> -------------------------------------------------
>
>                 Key: HBASE-16729
>                 URL: https://issues.apache.org/jira/browse/HBASE-16729
>             Project: HBase
>          Issue Type: Wish
>    Affects Versions: 2.0.0
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16729.v0.patch, HBASE-16729.v1.patch, 
> HBASE-16729.v2.patch
>
>
> Current empty FilterList filters all data, because the 
> FilterList#isFamilyEssential always returns false which causes the null cell 
> retrieved by RegionScannerImpl.storeHeap.
> It seems to me that empty FilterList should do nothing, because the following 
> code is common.
> {noformat}
> private static Filter makeFilter() {
>   FilterList filterList = new FilterList ();
>   for (some conditions) {
>     // add some filters. Or nothing to add.
>   }
>   return filterList;
> }
> {noformat}
> If we keep the current logic which filters all data, we should add enough 
> comments to explain it. Or add the FilterList#size() or FilterList#empty() 
> for preventing filtering all data.
> Any comments? Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to