[ 
https://issues.apache.org/jira/browse/HBASE-16724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Singhi updated HBASE-16724:
----------------------------------
    Fix Version/s: 1.4.0

Pushed to branch-1.
On branch-1.3 the modified test in the patch failed. Didn't check further 
branches.
{code}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.security.access.TestAccessController
Tests run: 61, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 88.736 sec <<< 
FAILURE! - in org.apache.hadoop.hbase.security.access.TestAccessController
testSnapshot(org.apache.hadoop.hbase.security.access.TestAccessController)  
Time elapsed: 0.035 sec  <<< ERROR!
java.lang.NullPointerException: null
        at 
org.apache.hadoop.hbase.snapshot.SnapshotDescriptionUtils.isSnapshotOwner(SnapshotDescriptionUtils.java:364)
        at 
org.apache.hadoop.hbase.security.access.AccessController.preCloneSnapshot(AccessController.java:1335)
        at 
org.apache.hadoop.hbase.security.access.TestAccessController$70.run(TestAccessController.java:2053)
        at java.security.AccessController.doPrivileged(Native Method)
        at javax.security.auth.Subject.doAs(Subject.java:422)
        at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1614)
        at 
org.apache.hadoop.hbase.security.User$SecureHadoopUser.runAs(User.java:340)
        at 
org.apache.hadoop.hbase.security.access.SecureTestUtil.verifyAllowed(SecureTestUtil.java:177)
        at 
org.apache.hadoop.hbase.security.access.SecureTestUtil.verifyAllowed(SecureTestUtil.java:193)
        at 
org.apache.hadoop.hbase.security.access.TestAccessController.testSnapshot(TestAccessController.java:2063)


Results :

Tests in error:
  
TestAccessController.testSnapshot:2063->SecureTestUtil.verifyAllowed:193->SecureTestUtil.verifyAllowed:177
 ▒ NullPointer

Tests run: 61, Failures: 0, Errors: 1, Skipped: 0
{code}
Next time please run test locally also before attaching the patch.

> Snapshot owner can't clone
> --------------------------
>
>                 Key: HBASE-16724
>                 URL: https://issues.apache.org/jira/browse/HBASE-16724
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 2.0.0
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-16724-V2.patch, HBASE-16724-V3.patch, 
> HBASE-16724-branch-1.1.patch, HBASE-16724-branch-1.2.patch, 
> HBASE-16724-branch-1.3.patch, HBASE-16724-branch-1.patch, HBASE-16724.patch
>
>
> Currently only Global admin has the access of cloning a snapshot.
> In AccessController,
> {code}
>   @Override
>   public void preCloneSnapshot(final 
> ObserverContext<MasterCoprocessorEnvironment> ctx,
>       final SnapshotDescription snapshot, final HTableDescriptor 
> hTableDescriptor)
>       throws IOException {
>     requirePermission(getActiveUser(ctx), "cloneSnapshot " + 
> snapshot.getName(), Action.ADMIN);
>   }
> {code}
> Snapshot owner should be able to  clone it, need to add a check like,
> {code}
> SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to