[ 
https://issues.apache.org/jira/browse/HBASE-16828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Rodionov updated HBASE-16828:
--------------------------------------
    Description: 
>From Stacks review:
{quote}
This is interesting... if I pass a set and a table as command lets me do, it 
runs the backup twice. I was sort of expecting one backup dir with all content 
in it. No biggie. Here is the command I ran (the -set included the table so the 
tool behavior avoids backup overwrite).
./hbase/bin/hbase --config ~/conf_hbase backup create full 
hdfs://ve0524.halxg.cloudera.com:8020/backup clicks -set s
{quote}

{quote}
The command I ran was $ ./hbase/bin/hbase --config ~/conf_hbase backup create 
full clicks I'm missing the backup location which probably explains the above. 
I'd think the tool would verify the command before going ahead and running a 
mapreduce job?
{quote}
{quote}
stack@ve0524:~$ ./hbase/bin/hbase --config ~/conf_hbase backup create

... does the tables 'option' not take a hyphen but all others do? Most of the 
time options are delimited by space but not always....
{quote}

{quote}
When required args are not supplied, dumping help/usage rather than ERROR is 
usual and user friendly.
{quote}

{quote}
What about consistency in errors, that sometimes commands are single letter, 
other times words, that descriptions in usage are not what is on the Option, 
that we do Options but don't use it to do Usage/help, and others.
{quote}

  was:
>From Stacks review:
{quote}
This is interesting... if I pass a set and a table as command lets me do, it 
runs the backup twice. I was sort of expecting one backup dir with all content 
in it. No biggie. Here is the command I ran (the -set included the table so the 
tool behavior avoids backup overwrite).
./hbase/bin/hbase --config ~/conf_hbase backup create full 
hdfs://ve0524.halxg.cloudera.com:8020/backup clicks -set s
{quote}

{quote}
The command I ran was $ ./hbase/bin/hbase --config ~/conf_hbase backup create 
full clicks I'm missing the backup location which probably explains the above. 
I'd think the tool would verify the command before going ahead and running a 
mapreduce job?
{quote}
{quote}
stack@ve0524:~$ ./hbase/bin/hbase --config ~/conf_hbase backup create

... does the tables 'option' not take a hyphen but all others do? Most of the 
time options are delimited by space but not always....
{quote}

{quote}
When required args are not supplied, dumping help/usage rather than ERROR is 
usual and user friendly.
{quote}


> Make backup command-line tool interface consistent
> --------------------------------------------------
>
>                 Key: HBASE-16828
>                 URL: https://issues.apache.org/jira/browse/HBASE-16828
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16828-v1.patch
>
>
> From Stacks review:
> {quote}
> This is interesting... if I pass a set and a table as command lets me do, it 
> runs the backup twice. I was sort of expecting one backup dir with all 
> content in it. No biggie. Here is the command I ran (the -set included the 
> table so the tool behavior avoids backup overwrite).
> ./hbase/bin/hbase --config ~/conf_hbase backup create full 
> hdfs://ve0524.halxg.cloudera.com:8020/backup clicks -set s
> {quote}
> {quote}
> The command I ran was $ ./hbase/bin/hbase --config ~/conf_hbase backup create 
> full clicks I'm missing the backup location which probably explains the 
> above. I'd think the tool would verify the command before going ahead and 
> running a mapreduce job?
> {quote}
> {quote}
> stack@ve0524:~$ ./hbase/bin/hbase --config ~/conf_hbase backup create
> ... does the tables 'option' not take a hyphen but all others do? Most of the 
> time options are delimited by space but not always....
> {quote}
> {quote}
> When required args are not supplied, dumping help/usage rather than ERROR is 
> usual and user friendly.
> {quote}
> {quote}
> What about consistency in errors, that sometimes commands are single letter, 
> other times words, that descriptions in usage are not what is on the Option, 
> that we do Options but don't use it to do Usage/help, and others.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to