[ 
https://issues.apache.org/jira/browse/HBASE-16783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584529#comment-15584529
 ] 

ramkrishna.s.vasudevan commented on HBASE-16783:
------------------------------------------------

My only concern was is it ok to add a new API in BBLOS though it is ugly?  
Since BBLOS handles curBuf it is difficult to bring out the buffer management 
outside without making other APIs also in that new class. 
Else for now can go with BBLOS itself but i fear we may have to do some 
refactoring later. thanks for the input. Will udpate the patch. 

> Use ByteBufferPool for the header and message during Rpc response
> -----------------------------------------------------------------
>
>                 Key: HBASE-16783
>                 URL: https://issues.apache.org/jira/browse/HBASE-16783
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>         Attachments: HBASE-16783.patch, HBASE-16783_1.patch, 
> HBASE-16783_2.patch, HBASE-16783_3.patch
>
>
> With ByteBufferPool in place we could avoid the byte[] creation in 
> RpcServer#createHeaderAndMessageBytes and try using the Buffer from the pool 
> rather than creating byte[] every time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to