[ 
https://issues.apache.org/jira/browse/HBASE-16828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586284#comment-15586284
 ] 

Hadoop QA commented on HBASE-16828:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s {color} 
| {color:red} HBASE-16828 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12834005/HBASE-16828-v4.patch |
| JIRA Issue | HBASE-16828 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4083/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Make backup command-line tool interface consistent
> --------------------------------------------------
>
>                 Key: HBASE-16828
>                 URL: https://issues.apache.org/jira/browse/HBASE-16828
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16828-v1.patch, HBASE-16828-v2.patch, 
> HBASE-16828-v3.patch, HBASE-16828-v4.patch
>
>
> From Stacks review:
> {quote}
> This is interesting... if I pass a set and a table as command lets me do, it 
> runs the backup twice. I was sort of expecting one backup dir with all 
> content in it. No biggie. Here is the command I ran (the -set included the 
> table so the tool behavior avoids backup overwrite).
> ./hbase/bin/hbase --config ~/conf_hbase backup create full 
> hdfs://ve0524.halxg.cloudera.com:8020/backup clicks -set s
> {quote}
> {quote}
> The command I ran was $ ./hbase/bin/hbase --config ~/conf_hbase backup create 
> full clicks I'm missing the backup location which probably explains the 
> above. I'd think the tool would verify the command before going ahead and 
> running a mapreduce job?
> {quote}
> {quote}
> stack@ve0524:~$ ./hbase/bin/hbase --config ~/conf_hbase backup create
> ... does the tables 'option' not take a hyphen but all others do? Most of the 
> time options are delimited by space but not always....
> {quote}
> {quote}
> When required args are not supplied, dumping help/usage rather than ERROR is 
> usual and user friendly.
> {quote}
> {quote}
> What about consistency in errors, that sometimes commands are single letter, 
> other times words, that descriptions in usage are not what is on the Option, 
> that we do Options but don't use it to do Usage/help, and others.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to