[
https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-4969:
-------------------------------
Attachment: HBASE-4969.D669.1.patch
khemani requested code review of "HBASE-4969 [jira] tautology in
HRegionInfo.readFields".
Reviewers: nspiegelberg, dhruba, JIRA
as in title
TEST PLAN
minor change.
REVISION DETAIL
https://reviews.facebook.net/D669
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/1479/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> tautology in HRegionInfo.readFields
> -----------------------------------
>
> Key: HBASE-4969
> URL: https://issues.apache.org/jira/browse/HBASE-4969
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: HBASE-4969.D669.1.patch
>
>
> In HRegionInfo.readFields() the following looks wrong to me
> } else if (getVersion() == VERSION) {
> it is always true.
> Should it have been
> } else if (getVersion() == version) {
> version is a local variable where the deserialized-version is stored.
> (I am struggling with another issue where after applying some patches -
> including "HBASE-4388 Second start after migration from 90 to trunk crashes"
> my version of hbase-92 HRegionInfo.readFields() tries to find HTD in
> HRegionInfo and fails)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
