[ 
https://issues.apache.org/jira/browse/HBASE-16608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591161#comment-15591161
 ] 

Anoop Sam John commented on HBASE-16608:
----------------------------------------

So the net run for PE took ~15 secs more for COmpactingMemstore but that mainly 
comes from the GC issue.. We can see total GC pause is ~33 secs more with 
CompactingMemstore.   I feel the remaining jiras on better policy making on 
merges will solve this and we will see much more adv.

So the last patch on new RB request is having only diff wrt the way we combine 
MSLABs from all merging segments.  Instead of create a new HeapMSLAB and copy 
pooled chunk refs from those into the new MSLAB's Q and do stuff of referring 
nextMSLAB etc, it is done in a simpler way creating a new impl of MSLAB which 
just wraps N MSLABs.  Other than that part all other parts are same as in 
latest patch that [~anastas] attached here.
Am +1 to commit this.   Will commit only after +1 from 
[~ebortnik]/[~anastas]/[~eshcar]

[~devaraj] Ur -1 was based on comments from Me/Ram.   That bug was fixed in _08 
version of patch itself but that was still having an issue of creating more GCs 
as there were some issue with returning back chunks to pool.  The _09 version 
fixes this.  Both me and Ram ran PE tests with 50 client threads and pumping 
150GB of data and all looks fine..  Hope u will be ok to revoke ur -1. Thanks 
DD.


> Introducing the ability to merge ImmutableSegments without copy-compaction or 
> SQM usage
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-16608
>                 URL: https://issues.apache.org/jira/browse/HBASE-16608
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anastasia Braginsky
>            Assignee: Anastasia Braginsky
>         Attachments: HBASE-16417-V02.patch, HBASE-16417-V04.patch, 
> HBASE-16417-V06.patch, HBASE-16417-V07.patch, HBASE-16417-V08.patch, 
> HBASE-16417-V10.patch, HBASE-16608-V01.patch, HBASE-16608-V03.patch, 
> HBASE-16608-V04.patch, HBASE-16608-V08.patch, HBASE-16608-V09.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to