[ https://issues.apache.org/jira/browse/HBASE-16870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591405#comment-15591405 ]
Hadoop QA commented on HBASE-16870: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 3 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 42s {color} | {color:green} branch-1.1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s {color} | {color:green} branch-1.1 passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s {color} | {color:green} branch-1.1 passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 30s {color} | {color:green} branch-1.1 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 21s {color} | {color:green} branch-1.1 passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 52s {color} | {color:red} hbase-server in branch-1.1 has 80 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 31s {color} | {color:red} hbase-server in branch-1.1 failed with JDK v1.8.0_101. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s {color} | {color:green} branch-1.1 passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 41s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s {color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s {color} | {color:green} the patch passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 34s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 16s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 12m 34s {color} | {color:green} The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 16s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 11s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 24s {color} | {color:red} hbase-server in the patch failed with JDK v1.8.0_101. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s {color} | {color:green} the patch passed with JDK v1.7.0_80 {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 94m 22s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 36s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 126m 50s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.wal.TestBoundedRegionGroupingProvider | | | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | hadoop.hbase.mapred.TestTableMapReduceUtil | | | hadoop.hbase.wal.TestDefaultWALProviderWithHLogKey | | | hadoop.hbase.wal.TestDefaultWALProvider | | | hadoop.hbase.mapred.TestTableSnapshotInputFormat | | | hadoop.hbase.mapred.TestTableInputFormat | | | hadoop.hbase.wal.TestWALSplitCompressed | | | hadoop.hbase.wal.TestWALFactory | | | hadoop.hbase.wal.TestWALSplit | | | hadoop.hbase.mapred.TestTableMapReduce | | | hadoop.hbase.client.TestSnapshotCloneIndependence | | | hadoop.hbase.wal.TestWALFiltering | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:35e2245 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12834342/HBASE-16870-branch-1.1-v1.patch | | JIRA Issue | HBASE-16870 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux a35c99c69bbf 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/hbase.sh | | git revision | branch-1.1 / 4e304b3 | | Default Java | 1.7.0_80 | | Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-oracle:1.7.0_80 | | findbugs | v3.0.0 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/4117/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/4117/artifact/patchprocess/branch-javadoc-hbase-server-jdk1.8.0_101.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/4117/artifact/patchprocess/patch-javadoc-hbase-server-jdk1.8.0_101.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/4117/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/4117/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/4117/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/4117/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Add the metrics of replication sources which were transformed from other dead > rs to ReplicationLoad > --------------------------------------------------------------------------------------------------- > > Key: HBASE-16870 > URL: https://issues.apache.org/jira/browse/HBASE-16870 > Project: HBase > Issue Type: Bug > Components: Replication > Reporter: Guanghao Zhang > Assignee: Guanghao Zhang > Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16870-ADDENDUM-v1.patch, > HBASE-16870-ADDENDUM.patch, HBASE-16870-branch-1-v1.patch, > HBASE-16870-branch-1.1-v1.patch, HBASE-16870-branch-1.1.patch, > HBASE-16870-branch-1.3-v1.patch, HBASE-16870-branch-1.3.patch, > HBASE-16870-branch-1.patch, HBASE-16870-v1.patch, HBASE-16870.patch > > > {code} > private void buildReplicationLoad() { > // get source > List<ReplicationSourceInterface> sources = > this.replicationManager.getSources(); > List<MetricsSource> sourceMetricsList = new ArrayList<MetricsSource>(); > for (ReplicationSourceInterface source : sources) { > if (source instanceof ReplicationSource) { > sourceMetricsList.add(((ReplicationSource) > source).getSourceMetrics()); > } > } > // get sink > MetricsSink sinkMetrics = this.replicationSink.getSinkMetrics(); > this.replicationLoad.buildReplicationLoad(sourceMetricsList, sinkMetrics); > } > {code} > The buildReplicationLoad method in o.a.h.h.r.r.Replication didn't consider > the replication source which were transformed from other died rs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)