[
https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165589#comment-13165589
]
stack commented on HBASE-4682:
------------------------------
Nice test. For sure its medium sized? Takes < 50 seconds?
This bit seems a little messy:
{code}
- put.add(kv);
+ if (kv.isDelete()) {
+ context.write(key, new Delete(kv));
+ } else {
+ if (put == null) {
+ put = new Put(key.get());
+ }
+ put.add(kv);
+ }
}
- return put;
+ if (put != null) {
+ context.write(key, put);
+ }
{code}
We write the context if its a delete but if a put, we make a put instance and
then do the context.write later... can they not both do context.write in same
place or share the context.write invocation (if context.write takes a Mutation).
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt, 4682-v2.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be
> exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
