[
https://issues.apache.org/jira/browse/HBASE-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15601027#comment-15601027
]
ramkrishna.s.vasudevan commented on HBASE-16929:
------------------------------------------------
bq.Even though def impl is there in RegionScanner, still it complaints ! Why
so? U know the real reason?
Ya even I have the same question. Now if we try to implement the RegionScanner
in our own hbase locally without implementing shipped() method does that throw
error? Is it because
Phoenix2.0 is not in java 8 and still in java 7?
> Move default method of shipped to Shipper interface
> ---------------------------------------------------
>
> Key: HBASE-16929
> URL: https://issues.apache.org/jira/browse/HBASE-16929
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 2.0.0
>
> Attachments: 16929.v1.txt
>
>
> HBASE-16626 added default method of shipped() to RegionScanner.
> However, when building master branch of Phoenix against 2.0 SNAPSHOT, I got:
> {code}
> [ERROR]
> /a/phoenix/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionScanner.java:[27,8]
> org.apache.phoenix.coprocessor.DelegateRegionScanner is not abstract and
> does not override abstract method shipped() in
> org.apache.hadoop.hbase.regionserver.Shipper
> [ERROR]
> /a/phoenix/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:[344,36]
> <anonymous org.apache.phoenix.coprocessor.BaseScannerRegionObserver$1> is
> not abstract and does not override abstract method shipped() in
> org.apache.hadoop.hbase.regionserver.Shipper
> {code}
> Here is the snippet for DelegateRegionScanner:
> {code}
> public class DelegateRegionScanner implements RegionScanner {
> {code}
> It seems adding default method in RegionScanner is not enough for downstream
> projects.
> After moving the default method to Shipper interface, the above two
> compilation errors are gone in Phoenix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
