[
https://issues.apache.org/jira/browse/HBASE-16886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15601424#comment-15601424
]
huzheng commented on HBASE-16886:
---------------------------------
Thanks for review and advise . I really appreciate it.
I did following modifications for patch v2:
1. currently, class inheritance relationships are below. so I move
locateRegionsInRange() method to ScannerCallable for sharing between
SmallReversedScannerCallable and ReversedScannerCallable.
{code}
SmallReversedScannerCallable -> SmallScannerCallable -> ScannerCallable
^
|
ReversedScannerCallable
{code}
2. move prepare() method to ScannerCallable seems confuse. so, I create a new
ReversedScannerCallablePrepareHandler class, both SmallReversedScannerCallable
and ReversedScannerCallable share this handler.
3. define SmallReversedScannerCallable in ClientSmallReversedScanner , just
like ClientSmallScanner.
4. add javaDoc for SmallReversedScannerCallable.
5. refactor isFirstLocatedRegion to isFirstRegionToLocate. regionChanged flag
have different meaning compare with isFirstRegionToLocate, so I prefer to
isFirstLocatedRegion.
How do you think?
> hbase-client: scanner with reversed=true and small=true gets no result
> ----------------------------------------------------------------------
>
> Key: HBASE-16886
> URL: https://issues.apache.org/jira/browse/HBASE-16886
> Project: HBase
> Issue Type: Bug
> Reporter: huzheng
> Labels: patch
> Attachments: HBASE-16886.v0.patch, HBASE-16886.v1.patch,
> TestReversedSmallScan.java
>
>
> Assume HBase have four regions (-oo, b), [b, c), [c, d), [d,+oo) , and all
> rowKeys are located in region [d, +oo). using a Reversed Small Scanner will
> get no result.
> Attached file show this failed test case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
