[ 
https://issues.apache.org/jira/browse/HBASE-16937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15604532#comment-15604532
 ] 

Anoop Sam John commented on HBASE-16937:
----------------------------------------

bq.admin.snapshot(new SnapshotDescription(snapshotName, tableName, 
snapshotType));
This is SnapshotDescription our POJO object right?  That is public exposed and 
used in Admin public class.  So this means we will change the constructor to 
take a PB type?  We tried to avoid that fully from our Public exposed APIs and 
this work of SnapshotDescription pojo was part of that.
cc [~ram_krish]

> Replace SnapshotType protobuf conversion when we can directly use the pojo 
> object
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-16937
>                 URL: https://issues.apache.org/jira/browse/HBASE-16937
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16937-v0.patch, HBASE-16937-v1.patch
>
>
> mostly find & replace work:
> replace the back and forth protobuf conversion when we can just use the 
> client SnapshotType enum.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to