[
https://issues.apache.org/jira/browse/HBASE-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-4987:
-------------------------------
Attachment: HBASE-4987.D675.3.patch
khemani updated the revision "HBASE-4987 [jira] wrong use of incarnation var in
SplitLogManager".
Reviewers: tedyu, nspiegelberg, dhruba, JIRA
narrowed the synchronization block
This fixes of two issues
1. double counting of batch.installed is fixed. This is a simple fix. If the
new Task(batch) is not used then decrement batch.installed--. No lock is
requited to decrement batch.installed. Only one thread ever looks at this value.
2. There was an unhandled race between the zookeeper-callback thread calling
setDone() on a task not part of any batch and another thread incorporating that
task into a batch. That is now fixed.
REVISION DETAIL
https://reviews.facebook.net/D675
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
> wrong use of incarnation var in SplitLogManager
> -----------------------------------------------
>
> Key: HBASE-4987
> URL: https://issues.apache.org/jira/browse/HBASE-4987
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.0
>
> Attachments: HBASE-4987.D675.1.patch, HBASE-4987.D675.2.patch,
> HBASE-4987.D675.3.patch
>
>
> @Ramakrishna found and analyzed an issue in SplitLogManager. But I don't
> think that the fix is correct. Will upload a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira