[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612387#comment-15612387
]
Sean Busbey commented on HBASE-16835:
-------------------------------------
{quote}
bq. We don't do protoc as part of our build. It is a step done outside of build
to generate src that is checked in for use by build.
So we need to change the precommit job config? Sean Busbey What's purpose of
running protoc check in precommit?
{quote}
checking that protoc builds still work after a change was added in 2014 by
[~tedyu] and [~apurtell] in HBASE-11375 after we had some changes come in that
broke doing a protoc build. The fact that we don't usually do a protoc run when
building makes it more important to check in precommit (IMHO) because that
means we won't discover the problem until far after the change goes in.
Now that we're doing gymnastics around protobuf, we should probably make sure
we can do end-to-end regeneration of all the protobuf stuff in our precommit
job, since we have the advantage of requiring a consistent build environment
(via docker).
> Revisit the zookeeper usage at client side
> ------------------------------------------
>
> Key: HBASE-16835
> URL: https://issues.apache.org/jira/browse/HBASE-16835
> Project: HBase
> Issue Type: Sub-task
> Components: Client, Zookeeper
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-16835.patch
>
>
> Watcher or not.
> Curator or not.
> Keep connection or not.
> ...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
