[
https://issues.apache.org/jira/browse/HBASE-16957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Umesh Agashe updated HBASE-16957:
---------------------------------
Attachment: HBASE-16957-jbase-14439.v2.patch
Uploading patch after updating Javadoc for MasterStorage.getChores() as
suggested. For convenience here are the changes:
{code}
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/MasterStorage.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/MasterStorage.java
index bb82512..2f3b4a4 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/MasterStorage.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/MasterStorage.java
@@ -68,7 +68,14 @@ public abstract class MasterStorage<IDENTIFIER extends
StorageIdentifier> {
/**
* Get Chores that are required to be run from time to time for the
underlying MasterStorage
- * implementation.
+ * implementation. A few setup methods e.g. {@link #enableSnapshots()} may
have their own chores.
+ * The returned list of chores or their configuration may vary depending on
when in sequence
+ * this method is called with respect to other methods. Generally, a call to
this method for
+ * getting and scheduling chores, needs to be after storage is setup
properly by calling those
+ * methods first.
+ *
+ * Please refer to the documentation of specific method implementation for
more details.
+ *
* @param stopper the stopper
* @return storage chores.
*/
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/legacy/LegacyMasterStorage.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/legacy/LegacyMasterStorage.java
index 0f622fd..aa4de2c 100644
---
a/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/legacy/LegacyMasterStorage.java
+++
b/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/legacy/LegacyMasterStorage.java
@@ -128,6 +128,10 @@ public class LegacyMasterStorage extends
MasterStorage<LegacyPathIdentifier> {
return chores;
}
+ /**
+ * This method modifies chores configuration for snapshots. Please call this
method before
+ * instantiating and scheduling list of chores with {@link
#getChores(Stoppable, Map)}.
+ */
@Override
public void enableSnapshots() {
super.enableSnapshots();
{code}
> Remove directory layout/ filesystem references from Cleaners and a few other
> modules in master
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-16957
> URL: https://issues.apache.org/jira/browse/HBASE-16957
> Project: HBase
> Issue Type: Sub-task
> Components: Filesystem Integration, master
> Reporter: Umesh Agashe
> Assignee: Umesh Agashe
> Attachments: HBASE-16957-hbase-14439.v1.patch,
> HBASE-16957-jbase-14439.v2.patch
>
>
> Remove directory layout/ filesystem references from Cleaners and a few other
> modules in master
> {code}
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterStatusServlet.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileLinkCleaner.java
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
