[
https://issues.apache.org/jira/browse/HBASE-16952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614355#comment-15614355
]
Duo Zhang commented on HBASE-16952:
-----------------------------------
+1.
And the findbugs warnings are from the shaded protobuf classes, not the
generated ones. We have already exclude the generated files in
findbugs-exclude.xml. I think we should also exclude the shaded sources?
> Replace hadoop-maven-plugins with protobuf-maven-plugin for building protos
> ---------------------------------------------------------------------------
>
> Key: HBASE-16952
> URL: https://issues.apache.org/jira/browse/HBASE-16952
> Project: HBase
> Issue Type: Task
> Components: build
> Reporter: stack
> Assignee: stack
> Attachments: HBASE-16952.master.001.patch,
> HBASE-16952.master.002.patch, HBASE-16952.master.003.patch,
> HBASE-16952.master.003.patch
>
>
> hadoop-maven-plugins takes less configuration and avoids duplication --
> having to add .proto file in protobuf dir as well as add it explicitly to
> pom.xml. This plugin also lets you set more than one source
> (hadoop-maven-plugins expects you to compile first w/ one dir and then the
> other).
> Thanks to [~Apache9] for pointing out this plugin.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)