[
https://issues.apache.org/jira/browse/HBASE-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15618370#comment-15618370
]
stack commented on HBASE-16955:
-------------------------------
The extension mechanism that figures our environment needed to choose right
version of protoc seems to require mvn 3.1 at least:
https://github.com/trustin/os-maven-plugin/issues/21 Produces this exception
when hbase-protocol-shaded runs:
{code}
[WARNING] Failed to inject repository session properties.
java.lang.NoSuchMethodError:
org.apache.maven.execution.MavenSession.getRepositorySession()Lorg/eclipse/aether/RepositorySystemSession;
at
kr.motd.maven.os.RepositorySessionInjector.injectRepositorySession(RepositorySessionInjector.java:22)
at
kr.motd.maven.os.DetectExtension.injectSession(DetectExtension.java:148)
at
kr.motd.maven.os.DetectExtension.afterProjectsRead(DetectExtension.java:107)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:274)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
{code}
We run with Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T16:41:47+00:00) so should be ok.
Its warning only and stuff seems to keep going.
Then this failure when hbase-protocol-shaded runs is messing us up (just for
hbase-protocol-shaded... the other pb builds work)
{code}
[ERROR]
/testptch/hbase/hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/util/ForeignExceptionUtil.java:[30,77]
package org.apache.hadoop.hbase.shaded.protobuf.generated.ErrorHandlingProtos
does not exist
[ERROR]
/testptch/hbase/hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/util/ForeignExceptionUtil.java:[41,45]
cannot find symbol
symbol: class ForeignExceptionMessage
location: class org.apache.hadoop.hbase.util.ForeignExceptionUtil
{code}
... digging.
Works locally of course.
> Fixup precommit protoc check to do new distributed protos and pb 3.1.0 build
> ----------------------------------------------------------------------------
>
> Key: HBASE-16955
> URL: https://issues.apache.org/jira/browse/HBASE-16955
> Project: HBase
> Issue Type: Task
> Components: build, Protobufs
> Reporter: stack
> Assignee: stack
> Attachments: nothing_change.txt, nothing_change2.txt,
> nothing_change2.txt, nothing_change2.txt, nothing_change2.txt
>
>
> HBASE-15638 Shade protobuf and a follow-ons changed how we do protobufs.
> One, protobufs are in the module they pertain to so distributed throughout
> the modules and secondly, we do 2.5.0 pb for externally consumed protobuf --
> e.g. Coprocessor Endpoints -- but internally we use protobuf 3.1.0.
> A precommit check looks to see if any proto changes break protoc compile.
> This task is about updating the precommit to accommodate the changes brought
> about by HBASE-15638.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
