[
https://issues.apache.org/jira/browse/HBASE-16945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621790#comment-15621790
]
Yu Li edited comment on HBASE-16945 at 10/31/16 10:14 AM:
----------------------------------------------------------
Some minor comments, other parts LGTM:
1. For the protected {{updateCachedLocation}} method of {{AsyncRegionLocator}}
line 404, change to {{if (!canUpdate(newLoc, oldLoc))}}
2. Considering also abstract and form a {{removeFromCache}} method so we could
directly invoke it from somewhere else if needed in the future? I mean line
428-441 of {{AsyncRegionLocator}}
was (Author: carp84):
Some minor comments, other parts LGTM:
1. For the protected {{updateCachedLocation}} method of {{AsyncRegionLocator}}
line 404, change to {{if (!canUpdate(newLoc, oldLoc))}}
2. Considering also abstract and form a {{removeFromCache}} method so we could
directly invoke it from somewhere else if needed in the future?
> Implement AsyncRegionLocator
> ----------------------------
>
> Key: HBASE-16945
> URL: https://issues.apache.org/jira/browse/HBASE-16945
> Project: HBase
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-16945-v1.patch, HBASE-16945.patch
>
>
> Will implement it based on the small scan introduced in HBASE-16932 and the
> async zk cluster registry introduced in HBASE-16835.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
