[ 
https://issues.apache.org/jira/browse/HBASE-16945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622029#comment-15622029
 ] 

Duo Zhang commented on HBASE-16945:
-----------------------------------

{quote}
1. For the protected updateCachedLocation method of AsyncRegionLocator line 
404, change to if (!canUpdate(newLoc, oldLoc))
{quote}

They are not same. 
!(oldLoc != null && oldLoc.getSeqNum() <= loc.getSeqNum() && 
oldLoc.getServerName().equals(loc.getServerName()))
= oldLoc == null || oldLoc.getSeqNum() > loc.getSeqNum() || 
!oldLoc.getServerName().equals(loc.getServerName())

And for line 404, the condition is
oldLoc != null && (oldLoc.getSeqNum() > newLoc.getSeqNum()  || 
oldLoc.getServerName().equals(newLoc.getServerName()))



> Implement AsyncRegionLocator
> ----------------------------
>
>                 Key: HBASE-16945
>                 URL: https://issues.apache.org/jira/browse/HBASE-16945
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16945-v1.patch, HBASE-16945.patch
>
>
> Will implement it based on the small scan introduced in HBASE-16932 and the 
> async zk cluster registry introduced in HBASE-16835.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to