[
https://issues.apache.org/jira/browse/HBASE-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-16971:
---------------------------
Description:
We should pass the “effectiveDurability” to the doWALAppend() metohd.
{code:title=HRegion.java|borderStyle=solid}
private Result doDelta(...) {
Durability effectiveDurability =
getEffectiveDurability(mutation.getDurability());
Map<Store, List<Cell>> forMemStore =
new HashMap<Store, List<Cell>>(mutation.getFamilyCellMap().size());
// Reckon Cells to apply to WAL -- in returned walEdit -- and what to
add to memstore and
// what to return back to the client (in 'forMemStore' and 'results'
respectively).
WALEdit walEdit = reckonDeltas(op, mutation, effectiveDurability,
forMemStore, results);
// Actually write to WAL now if a walEdit to apply.
if (walEdit != null && !walEdit.isEmpty()) {
writeEntry = doWALAppend(walEdit, durability, nonceGroup, nonce);
} else {
}
{code}
was:
We should pass the “effectiveDurability” to the doWALAppend() metohd.
{code:title=Bar.java|borderStyle=solid}
private Result doDelta(...) {
Durability effectiveDurability =
getEffectiveDurability(mutation.getDurability());
Map<Store, List<Cell>> forMemStore =
new HashMap<Store, List<Cell>>(mutation.getFamilyCellMap().size());
// Reckon Cells to apply to WAL -- in returned walEdit -- and what to
add to memstore and
// what to return back to the client (in 'forMemStore' and 'results'
respectively).
WALEdit walEdit = reckonDeltas(op, mutation, effectiveDurability,
forMemStore, results);
// Actually write to WAL now if a walEdit to apply.
if (walEdit != null && !walEdit.isEmpty()) {
writeEntry = doWALAppend(walEdit, durability, nonceGroup, nonce);
} else {
}
{code}
> The passed durability of Append/Increment doesn’t be used in wal sync.
> ----------------------------------------------------------------------
>
> Key: HBASE-16971
> URL: https://issues.apache.org/jira/browse/HBASE-16971
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: ChiaPing Tsai
> Assignee: ChiaPing Tsai
> Fix For: 2.0.0
>
> Attachments: HBASE-16971.v0.patch
>
>
> We should pass the “effectiveDurability” to the doWALAppend() metohd.
> {code:title=HRegion.java|borderStyle=solid}
> private Result doDelta(...) {
> Durability effectiveDurability =
> getEffectiveDurability(mutation.getDurability());
> Map<Store, List<Cell>> forMemStore =
> new HashMap<Store,
> List<Cell>>(mutation.getFamilyCellMap().size());
> // Reckon Cells to apply to WAL -- in returned walEdit -- and what
> to add to memstore and
> // what to return back to the client (in 'forMemStore' and 'results'
> respectively).
> WALEdit walEdit = reckonDeltas(op, mutation, effectiveDurability,
> forMemStore, results);
> // Actually write to WAL now if a walEdit to apply.
> if (walEdit != null && !walEdit.isEmpty()) {
> writeEntry = doWALAppend(walEdit, durability, nonceGroup, nonce);
> } else {
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
